Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude setting doesn't work #488

Closed
mark-wiemer opened this issue Sep 1, 2024 · 1 comment
Closed

Exclude setting doesn't work #488

mark-wiemer opened this issue Sep 1, 2024 · 1 comment
Assignees
@mark-wiemer
Labels
AHK v2 exclusive to AHK v2 bug something isn't working intellisense autocompletion, suggestions, etc.

Comments

@mark-wiemer
Copy link
Owner

mark-wiemer commented Sep 1, 2024 •
edited
Loading

The extension opens all AHK files in the workspace to determine what AHK version to use and update their icon accordingly. However, this interferes with the exclude logic of the new language server, as it reads any file that's opened, regardless of why the file was opened.

Ref thqby/vscode-autohotkey2-lsp#577 (comment)
@mark-wiemer mark-wiemer added the pre-release affects the most recent prerelease, not the stable release label Sep 1, 2024
@mark-wiemer mark-wiemer self-assigned this Sep 1, 2024
@mark-wiemer mark-wiemer changed the title [Pre-release] Exclude doesn't work Exclude setting doesn't work Sep 1, 2024
@mark-wiemer mark-wiemer moved this to Todo in (old) AHK++ Sep 1, 2024
@mark-wiemer mark-wiemer pinned this issue Sep 1, 2024
This was referenced Sep 2, 2024
Closed
Closed
@mark-wiemer mark-wiemer mentioned this issue Sep 17, 2024
Closed
@mark-wiemer mark-wiemer added intellisense autocompletion, suggestions, etc. bug something isn't working AHK v2 exclusive to AHK v2 and removed pre-release affects the most recent prerelease, not the stable release labels Sep 19, 2024
@mark-wiemer mark-wiemer mentioned this issue Oct 7, 2024
Closed
@mark-wiemer mark-wiemer moved this from Todo to In Progress in (old) AHK++ Oct 12, 2024
@mark-wiemer mark-wiemer mentioned this issue Oct 13, 2024
Merged
@mark-wiemer
Copy link
Owner Author

Fixed for 6.3.0 coming this weekend :)

@github-project-automation github-project-automation bot moved this from In Progress to Done in (old) AHK++ Oct 17, 2024
@mark-wiemer mark-wiemer mentioned this issue Oct 19, 2024
Merged
@mark-wiemer mark-wiemer unpinned this issue Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-wiemer mark-wiemer

Labels
AHK v2 exclusive to AHK v2 bug something isn't working intellisense autocompletion, suggestions, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mark-wiemer