-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Refactor: update everything #10
Conversation
I'm working on testing marked with this version to make sure it still works |
Bad news: Parse5 does not support node v4 so marked's tests in node v4 would break but all other tests work. should we wait on this or stop testing marked in node v4? we already quit testing in node v0.10 even though we still support it because of the testing framework (markedjs/marked#1366) |
What do you mean we still support it? I specifically remember dropping support in marked 0.6.0. |
@styfle You're right. I was thinking of how we stopped testing node v0.10 in marked v0.5.2 but still supported it until v0.6.0 We could do the same with node v4. stop testing it but still support it. |
It seems like it would be easy to accidentally introduce a breaking change if CI is not testing the environment we expect to support. |
We could still support it as in if someone brings up an issue we will fix it. If someone is still on node 4 chances are pretty good that they are on an old version of marked also. |
or maybe we can still run a simple test on node v4 that would just make sure we don't introduce syntax that that doesn't work in node v4. |
I see, those are both good options. If I recall, its not the Node support that was holding back marked but the Browser support. It was a coincidence that Node and IE had (almost) feature parity at one point. |
I think eslint with Once this is merged I will work on updating marked to use this promisified version |
I have refactored the code to upgrade all dependencies to the latest and better match marked's style.
Changes
ignoreDuplicateAttributes
option since parse5 doesn't support duplicate attributes any more (see inikulin/parse5@225d27f)istanbul
withnyc
(active version ofistanbul
)Fixes #5
Fixes #6