Add marked.esm, marked.js to git.ignore? #1898
calculuschild
started this conversation in
Ideas
Replies: 1 comment 2 replies
-
We can't remove them from the git repo since some users import them client side using It should be fine to include them in PRs since they are automatically overwritten once merged. In fact if they are included in a PR you can test that PR in our demo |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
My understanding is we don't want to have marked.esm, marked.js, or the other compiled files pushed in PRs generally? Would it make sense to officially just add them from the git.ignore file? I'm not a Git wizard so I'm not sure what the best practice is, but I find myself constantly almost submitting commits that include them.
Beta Was this translation helpful? Give feedback.
All reactions