Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1330

Closed
joshbruce opened this issue Sep 5, 2018 · 5 comments
Closed

Update dependencies #1330

joshbruce opened this issue Sep 5, 2018 · 5 comments
Labels

Comments

@joshbruce
Copy link
Member

What pain point are you perceiving?.

Security vulnerability due to devDependencies in package.json. It's on lodash, which is most likely the dependency of a dependency. While this doesn't negatively effect our users it might cause problems with automatic tracking databases that don't distinguish between dependencies (which Marked has none) and devDependencies (which Marked has a few).

Describe the solution you'd like

Some type of dependency check protocol we can perform. Maybe on a somewhat rotating basis so one of us doesn't get stuck doing it all the time. Something captured in the contributing documentation; who knows, maybe someone from the community would be willing to step up to make sure we're up to date and whatnot...just spitballing.

@styfle
Copy link
Member

styfle commented Sep 6, 2018

@joshbruce I actually sent a private message about this.

We have a solution...GitHub tracks dependencies and shows a notification for these vulnerabilities.

image

In this case, it looks like @UziTech already forked the unmaintained repo as we discussed. The fork can be found here: https://github.com/markedjs/html-differ

@UziTech UziTech mentioned this issue Sep 6, 2018
4 tasks
@joshbruce
Copy link
Member Author

@styfle: Yeah. I was thinking a way to be a bit more proactive about it and go beyond just security vulnerabilities. Make sure we're using the latest versions. Maybe even check if there's a replacement library that does something better. That sort of thing. Don't want to force it or create more work for us, of course.

@styfle
Copy link
Member

styfle commented Sep 10, 2018

If you just want some indicator that dependencies are out of date, we could add a badge that checks for this.

dep https://badgen.net/david/dep/markedjs/marked

dev https://badgen.net/david/dev/markedjs/marked

@UziTech
Copy link
Member

UziTech commented Sep 10, 2018

That wouldn't be a bad thing to add to the readme. I think not having any regular dependencies is one of the benefits of marked.

@styfle
Copy link
Member

styfle commented Sep 10, 2018

I created PR #1333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants