SmartyPants Shouldn't Do Typographic Substitutions In <code> Blocks

[richdouglasevans]

When SmartyPants is enabled, Marked is replacing -- with an en-dash inside <code> blocks.

Per the following comment on the SmartyPants website, I don't think it should.

SmartyPants does not modify characters within <pre>, <code>, <kbd>, or <script> tag blocks.

To Reproduce

git clone https://github.com/richdouglasevans/marked-code-issue.git
cd marked-code-issue
npm i
npm test

I am happy to dig into the code and sort this myself; I'm raising an issue so that I can first confirm with you the expected behaviour.

Issue was noticed here: cypress-io/cypress-documentation#923

[styfle]

Hi @richdouglasevans thanks for the bug report.

It took me as second to realize that you are using the html <code></code> instead of the backticks.

marked('--foo <code>--bar</code>', {smartypants: true});
// <p>–foo <code>–bar</code></p>

It looks like a workaround is to use backticks instead like so:

marked('--foo `--bar`', {smartypants: true});
// <p>–foo <code>--bar</code></p>

[richdouglasevans]

Aye, cheers Steven 👍

Yep, that works... the <code> blocks are being inserted by a component in my toolchain so I either need to rethink the way my toolchain works or solve this issue at source here.

I'll dig in and see if I can sort it here.