Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some failed commonmark examples #1474

Closed
Jocs opened this issue Apr 17, 2019 · 3 comments
Closed

Some failed commonmark examples #1474

Jocs opened this issue Apr 17, 2019 · 3 comments

Comments

@Jocs
Copy link
Contributor

Jocs commented Apr 17, 2019

We forked a copy of marked code in Mark Text in 2017. After every time marked release a new version, we will update the code of our fork, and we also fix some examples that failed through the commonmark test. You can see from this file. Some of the issues we fix, if you like, we also hope to help marked to fix these issues.
Finally, thank you again for your unselfish maintenance and return marked to life.

@UziTech
Copy link
Member

UziTech commented Apr 17, 2019

PRs are always welcome 😃👍

@calculuschild
Copy link
Contributor

calculuschild commented May 30, 2021

@Jocs is Marked.js still failing these tests for you? There have been a lot of updates in the last two years.

If there are still some cases that you have solved and Marked.js hasn't, we would love your help in fixing them with a PR!

Otherwise, @UziTech this issue is essentially a general "there are some Commonmark cases that don't pass". We already have each of those failing cases documented in our test suite (shouldfail: true), so maybe this issue is redundant and we can close it?

@Jocs
Copy link
Contributor Author

Jocs commented May 31, 2021

Marked.js has updated a lot, I think you can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants