Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot break line well #1537

Closed
hubenchang0515 opened this issue Aug 20, 2019 · 2 comments · Fixed by #1746
Closed

Cannot break line well #1537

hubenchang0515 opened this issue Aug 20, 2019 · 2 comments · Fixed by #1746
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@hubenchang0515
Copy link
Contributor

Describe the bug
Cannot use (WhiteSpace)(WhiteSpace)(Return) to break line while only one characher before it.

And if use special character, it will reset the character count

To Reproduce
Just input "a \nb".

  1. Marked Demo
  2. CommonMark Demo
  3. Marked before 0.6.1 doesn't have this bug
@UziTech UziTech added the L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue label Aug 20, 2019
@UziTech
Copy link
Member

UziTech commented Aug 20, 2019

I'm going to guess it was #1460 that changed it.

hubenchang0515 added a commit to hubenchang0515/marked that referenced this issue Aug 11, 2020
@hubenchang0515
fix bug : Cannot break line well [markedjs#1537](markedjs#1537)
95c5dde 
brought by [markedjs#1460](markedjs#1460)

**Describe the bug**
Cannot use **(WhiteSpace)(WhiteSpace)(Return)** to break line while only one characher before it.

And if use special character, it will reset the character count

**To Reproduce**
Just input "a  \nb".

1. [Marked Demo](https://marked.js.org/demo/?text=Cannot%20use%20**(WhiteSpace)(WhiteSpace)(Return)**%20to%20break%20line%20while%20only%20one%20characher%20before%20it.%20%20%0A%0Aa%20%20%0Acannot%20break%20line%20in%20marked.js%0A%0Aaa%20%20%0Acould%20break%20line%0A%0AAnd%20if%20use%20special%20character%2C%20it%20will%20reset%20the%20character%20count%20%20%20%0Aaaaaaaaaaaaaaa%60%5C%60a%20%20%0Acannot%20break%20line%20in%20marked.js&options=%7B%0A%20%22baseUrl%22%3A%20null%2C%0A%20%22breaks%22%3A%20false%2C%0A%20%22gfm%22%3A%20true%2C%0A%20%22headerIds%22%3A%20true%2C%0A%20%22headerPrefix%22%3A%20%22%22%2C%0A%20%22highlight%22%3A%20null%2C%0A%20%22langPrefix%22%3A%20%22language-%22%2C%0A%20%22mangle%22%3A%20true%2C%0A%20%22pedantic%22%3A%20false%2C%0A%20%22sanitize%22%3A%20false%2C%0A%20%22sanitizer%22%3A%20null%2C%0A%20%22silent%22%3A%20false%2C%0A%20%22smartLists%22%3A%20false%2C%0A%20%22smartypants%22%3A%20false%2C%0A%20%22xhtml%22%3A%20false%0A%7D&version=master)
2. [CommonMark Demo](https://spec.commonmark.org/dingus/?text=Cannot%20use%20**(WhiteSpace)(WhiteSpace)(Return)**%20to%20break%20line%20while%20only%20one%20characher%20before%20it.%20%20%0A%0Aa%20%20%0Acannot%20break%20line%20in%20marked.js%0A%0Aaa%20%20%0Acould%20break%20line%0A%0AAnd%20if%20use%20special%20character%2C%20it%20will%20reset%20the%20character%20count%20%20%20%0Aaaaaaaaaaaaaaa%60%5C%60a%20%20%0Acannot%20break%20line%20in%20marked.js)
3. [Marked before 0.6.1 doesn't have this bug](https://marked.js.org/demo/?text=Cannot%20use%20**(WhiteSpace)(WhiteSpace)(Return)**%20to%20break%20line%20while%20only%20one%20characher%20before%20it.%20%20%0A%0Aa%20%20%0Acannot%20break%20line%20in%20marked.js%0A%0Aaa%20%20%0Acould%20break%20line%0A%0AAnd%20if%20use%20special%20character%2C%20it%20will%20reset%20the%20character%20count%20%20%20%0Aaaaaaaaaaaaaaa%60%5C%60a%20%20%0Acannot%20break%20line%20in%20marked.js&options=%7B%0A%20%22baseUrl%22%3A%20null%2C%0A%20%22breaks%22%3A%20false%2C%0A%20%22gfm%22%3A%20true%2C%0A%20%22headerIds%22%3A%20true%2C%0A%20%22headerPrefix%22%3A%20%22%22%2C%0A%20%22highlight%22%3A%20null%2C%0A%20%22langPrefix%22%3A%20%22language-%22%2C%0A%20%22mangle%22%3A%20true%2C%0A%20%22pedantic%22%3A%20false%2C%0A%20%22sanitize%22%3A%20false%2C%0A%20%22sanitizer%22%3A%20null%2C%0A%20%22silent%22%3A%20false%2C%0A%20%22smartLists%22%3A%20false%2C%0A%20%22smartypants%22%3A%20false%2C%0A%20%22xhtml%22%3A%20false%0A%7D&version=0.6.1)
hubenchang0515 added a commit to hubenchang0515/marked that referenced this issue Aug 11, 2020
@hubenchang0515
fix bug : Cannot break line well [markedjs#1537](markedjs#1537)
edb56d3 
Cannot use **(WhiteSpace)(WhiteSpace)(Return)** to break line while only one characher before it.

And if use special character, it will reset the character count

brought by [markedjs#1460](markedjs#1460)
@hubenchang0515 hubenchang0515 mentioned this issue Aug 11, 2020
Merged
6 tasks
@hubenchang0515
Copy link
Contributor Author

I had fixed this and pull merge request
Please review at #1746

hubenchang0515 added a commit to hubenchang0515/marked that referenced this issue Aug 12, 2020
@hubenchang0515
fix bug : Cannot break line well [markedjs#1537](markedjs#1537)
aace579 
Cannot use **(WhiteSpace)(WhiteSpace)(Return)** to break line while only one characher before it.

And if use special character, it will reset the character count

brought by [markedjs#1460](markedjs#1460)
hubenchang0515 added a commit to hubenchang0515/marked that referenced this issue Aug 12, 2020
@hubenchang0515
fix bug : Cannot break line well [markedjs#1537](markedjs#1537)
52872d2 
Cannot use **(WhiteSpace)(WhiteSpace)(Return)** to break line while only one characher before it.

And if use special character, it will reset the character count

brought by [markedjs#1460](markedjs#1460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug : Cannot break line well [issue#1537] hubenchang0515/marked
2 participants
@UziTech @hubenchang0515