Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty cell is not generated???? #476

Closed
xiaofengzang opened this issue Aug 15, 2014 · 10 comments
Closed

Empty cell is not generated???? #476

xiaofengzang opened this issue Aug 15, 2014 · 10 comments

Comments

@xiaofengzang
Copy link

I have following mark down file which has a table, notice the 3rd column does not have value, and is empty

Header1 Header2 Header3 Header4
value1 value2 value4

it generates following html, notice it has 3 cells, I would expect there is an empty after value2. Anyone know what could be issue here?

..............
value1 value2 value4
@suan
Copy link

suan commented Jan 4, 2015

+1

This issue is preventing me from using marked for instant-markdown-d

@joshbruce
Copy link
Member

#980

@Feder1co5oave
Copy link
Contributor

Can't reproduce this without the markdown source you're feeding marked.
I tried something like this and it is parsed as expected:

| h1 | h2 | h3 | h4 |
| -- | -- | -- | -- |
| c1 | c2 |    | c4 |
<table>
<thead>
<tr>
<th>h1</th>
<th>h2</th>
<th>h3</th>
<th>h4</th>
</tr>
</thead>
<tbody>
<tr>
<td>c1</td>
<td>c2</td>
<td></td>
<td>c4</td>
</tr>
</tbody>
</table>

@kaelig
Copy link

kaelig commented Jun 28, 2018

Seems like this is still happening.

See https://marked.js.org/demo/?text=%7C%20a%20%7C%20b%20%7C%20c%20%7C%0A%7C%20-%20%7C%20-%20%7C%20-%20%7C%0A%7C%20a%20%7C%20%20%20%7C%20c%20%7C%0A

| a | b | c |
| - | - | - |
| a |   | c |

Care to reopen?


Workaround

Add &nbsp; in the empty cell:

See result

| a | b | c |
| - | - | - |
| a | &nbsp; | c |

@UziTech
Copy link
Member

UziTech commented Jun 28, 2018

@kaelig this was fixed in #1262 which has not been released yet

@kaelig
Copy link

kaelig commented Jun 28, 2018

Oh great! Thank you!

@SilentGert
Copy link

Hi,
I'm running into the same issue. Is there already a timeframe when the patch will be released?

Thanks

@styfle
Copy link
Member

styfle commented Aug 15, 2018

/cc @joshbruce - the Release Wrangler

@styfle styfle added this to the 0.5.0 - Commonmark Compliance milestone Aug 15, 2018
@joshbruce
Copy link
Member

@styfle: Are all the PRs we want in 0.5.0 in? I know we run on continuous delivery but we also tend to have a few more submitted before actually performing the release.

/cc @UziTech @davisjam

@styfle
Copy link
Member

styfle commented Aug 15, 2018

I'm happy now that we landed #1315

Ship it :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants