Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion failed link, there are () when #736

Closed
xuexb opened this issue Apr 6, 2016 · 1 comment · Fixed by #1135
Closed

Conversion failed link, there are () when #736

xuexb opened this issue Apr 6, 2016 · 1 comment · Fixed by #1135
Labels
category: links L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@xuexb
Copy link

xuexb commented Apr 6, 2016

Code:

var marked = require('marked');

var str = '[window.close()](javascript:window.close())';

console.log(str);
console.log(marked(str));

Output:

[window.close()](javascript:window.close())
<p><a href="javascript:window.close(">window.close()</a>)</p>

Right should be: (My opinion)

<p><a href="javascript:window.close()">window.close()</a></p>

by npm marked@0.3.5, nodejs@4.4.0


Thanks ~

@joshbruce
Copy link
Member

#984

@joshbruce joshbruce reopened this Jan 5, 2018
@joshbruce joshbruce added category: links L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: links L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants