-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare undeclared variables #991
Conversation
@learykara: Thank you for the PR. Is there a way to write a test for this? Want to make sure we don't get a regression. I don't know enough about the Marked test suite to know and I think it's somewhat custom. |
Adding |
I agree that adding |
This can also be prevented with eslint (no-unused-variable) |
LGTM @learykara could you add |
done @UziTech ! |
All right. Lots of good conversation here. Here's the plan:
Anything else we need to do? |
Declare undeclared variables
Fix for #990
These two variables are undeclared and throw an error in strict mode.