Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test lint instead of fixing it in travis #1086

Merged
merged 1 commit into from
Feb 26, 2018
Merged

test lint instead of fixing it in travis #1086

merged 1 commit into from
Feb 26, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 26, 2018

Description

Tell travis-ci to check for linting errors instead of fixing them.

Review

Submitter

  • All tests pass (CI should take care of this, once in place).
  • All lint checks pass (CI should take care of this, once in place).
  • Tests
    • Test(s) exist to ensure functionality works (if no new tests added, list which tests cover this functionality).
    • No tests required for this PR.
  • Is release:
    • Version in package.json has been updated (see RELEASE.md).
    • The marked.min.js has been updated; or,
    • release does not change library.

Reviewer

??

@joshbruce
Copy link
Member

I like it. This way we're helping people learn our standards and whatnot. With this and possible EditorConfig should be good stuff. We may want to reconsider at some point but would definitely like to hear the pain of the community first.

LGTM

@joshbruce joshbruce merged commit 4252cad into markedjs:master Feb 26, 2018
@joshbruce joshbruce mentioned this pull request Feb 26, 2018
7 tasks
@UziTech UziTech deleted the travis-lint branch April 5, 2018 14:38
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
test lint instead of fixing it in travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants