fix underscore adjacent to asterisk #1755
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/4n6qmogpz |
| @@ -222,7 +222,7 @@ inline.strong.start = edit(inline.strong.start) | |||
|
|
|||
| inline.strong.middle = edit(inline.strong.middle) | |||
| .replace(/punctuation/g, inline._punctuation) | |||
| .replace(/blockSkip/g, inline._blockSkip) | |||
| .replace(/overlapSkip/g, inline._overlapSkip) | |||
There was a problem hiding this comment.
this seems to be a typo from #1686
There was a problem hiding this comment.
Good catch. Did that make any difference on the tests?
There was a problem hiding this comment.
no it didn't. I think in order for us to pass all of the commonmark specs for em and strong we will need a recursive way to skip internal strong and em. For example **a **b** c** should output <strong>a <strong>b</strong> c</strong> but it does not. We would need some way to realize that b** is the end of the second strong and not the first.
There was a problem hiding this comment.
To be honest I don't know why anyone would actually do that. I'm ok with saying that is just garbage in garbage out but it is spec'd so we should probably try to find a way to fix it.
|
@joshbruce @davisjam we just need one more approval to merge this |
|
@UziTech: Not in a position to finish the approved portion of checklist or tag others apparently despite trying. |
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Marked version: 1.1.1
Markdown flavor: CommonMark
Description
Fix underscore adjacent to asterisk
Contributor
Committer
In most cases, this should be a different person than the contributor.