fix: update punctuation regex syntax for compatibility #3540
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the string to a regular expression. Then babel can transpile it correctly.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
approved these changes
Nov 20, 2024
|
We don't have any browser tests. I think if we are going to list specific browsers we should have some tests to make sure we are compatible. We support node >= 18 so really we support any browsers that have the same APIs as node 18 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
## [15.0.2](v15.0.1...v15.0.2) (2024-11-20) ### Bug Fixes * update punctuation regex syntax for compatibility ([#3540](#3540)) ([fd015f1](fd015f1))
Incompatible with React Native (Hermes Engine) |
|
It should work with the latest version facebook/hermes#1295 |
15.0.1 can work with the latest version of Hermes, but 15.0.2 introduced in this PR is not compatible. |
|
@0xDing Can you create a bug at https://github.com/facebook/hermes/ seems like they will have to fix it. |
|
Same issue with angular 18 but on Firefox only, 15.0.1 works fine, but 15.0.2 tells: "SyntaxError: invalid identity escape in regular expression" at getRegex marked.esm.js:45 on: |
|
@twistoliver what version of Firefox? |
|
Usually the last one, mine is 132.0.2 (64-bit), I’m currently investigating my tsconfig file as it’s maybe linked.
|
|
|
|
transpile to es5 and error occur |
|
anyway, the easiest way to fix is dont use edit to dynamic build regexp with _punctuation , just write it raw and babel will transpile it correct. another way is keep the code struct, then it should be or use a precompile script to generate regex info so It also ensures the neatness of regular spelling and allows babel to process these regular expressions. @UziTech Before we choose a solution, this PR should first be revert, and I'd love to PR to the solution you choose |
I don't think we need to release a version with this reverted. Just fixing it in the next version should be fine. There are multiple places const _punctuation = /[\p{P}\p{S}]/u
const _punctuationOrSpace = /[\s\p{P}\p{S}]/u
const _notPunctuationOrSpace = /[^\s\p{P}\p{S}]/uIt would be great if someone could also figure out a way to write a test for babel so this type of thing doesn't break in the future. |
BlueCat0
pushed a commit
to BlueCat0/marked
that referenced
this pull request
Nov 26, 2024
BlueCat0
pushed a commit
to BlueCat0/marked
that referenced
this pull request
Nov 26, 2024
5 tasks
|
I will stick on 15.0.1 until next release. Thank you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 13.0.1
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
as pr3229 said, the punctuation regex syntax is not supported in some browser
change the string to a regular expression. Then babel can transpile it correctly.
Expectation
Marked should work fine in most cases.
Result
Host environment reports error due to unsupported regex syntax.
What was attempted
-->
Contributor
Committer
In most cases, this should be a different person than the contributor.