Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suchtube --help giving Unexpected token error in node version 6.11.4 #9

Closed
rjoydip-zz opened this issue Dec 9, 2017 · 4 comments
Closed

Comments

@rjoydip-zz
Copy link

exports.start = async () => {
^
SyntaxError: Unexpected token (

@markets
Copy link
Owner

markets commented Dec 9, 2017

Hi @rjoydip thanks for your report!

Actually this package is tested against Node v7+ (7, 8, 9), as you can see here https://github.com/markets/suchtube/blob/master/.travis.yml#L6.

I'm not sure if there is an easy way to support v6 (I'm new to Node module development), since I use a async/await, which was introduced on v7 if I'm not wrong. I don't want to introduce babel and webpack to the build process. So, I'm going to improve docs to reflect current supported versions. You can easily manage different Node versions with a version manager like: creationix/nvm or tj/n.

@markets markets closed this as completed Dec 9, 2017
@rjoydip-zz
Copy link
Author

rjoydip-zz commented Dec 9, 2017

Yes it will be good to mention over docs also you can keep a check and rather throwing an error directly you can echo a message .You can check this tc39/proposal-async-await#78. I hope this will help you. 👍

@markets
Copy link
Owner

markets commented Dec 9, 2017

Hi @rjoydip I just pushed 3e38930. Thanks!

@rjoydip-zz
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants