Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Load Default button to Export dialog #326

Closed
markummitchell opened this issue May 16, 2019 · 4 comments
Closed

Add Load Default button to Export dialog #326

markummitchell opened this issue May 16, 2019 · 4 comments

Comments

@markummitchell
Copy link
Owner

Add Load Default button in the dialog for editing Export setttings.

This issue was suggested in #324

@markummitchell
Copy link
Owner Author

@https://github.com/k1moradi You can try out a pre-release by downloading from https://ci.appveyor.com/project/markummitchell/engauge-digitizer/branch/master/job/a6tx4db6ybyujxm9/artifacts. Use 7zip to open up the file.

@k1moradi
Copy link

k1moradi commented May 17, 2019

I checked the pre-release binary. In the export setting menu, I see the load default button, when I press it my default settings get loaded, but after pressing OK button and exporting, the CSV file did not have the format I set in the export menu. When I open the export settings menu, I see the original settings, not my defaults.

Before pressing the Load defaults:
image

After pressing the load defaults
image

I pressed OK and reopened the export format menu
image

You can see the OK button did not do what it should do.


PS: While you are working on this menu, from the shape of the screenshots you can see that the width and height of the settings menu are smaller than what they should be.

After adjusting the width on my computer.
image

I think this might be related to the display DPI on my computer. The following figure:
image

I checked with an old secondary display and this height and width problem was not there.
image

@markummitchell
Copy link
Owner Author

The Default button can be tested in Windows 64 bit by downloading and extracting https://ci.appveyor.com/project/markummitchell/engauge-digitizer/branch/master/job/y3ow8xpl52wx33qh/artifacts.

@k1moradi
Copy link

Thanks a lot! You are awesome! The "load default" button works now.
(I did not find your binary so I compiled the code myself. :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants