Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.4 deprecations #661

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Fix PHP 8.4 deprecations #661

wants to merge 1 commit into from

Conversation

LordSimal
Copy link

@LordSimal LordSimal commented Jan 10, 2025 •
edited
Loading

Resolves #654

This also updates the composer.lock file to contain the newest version of php-cs-fixer and therefore properly fix the implicit nullable type problem.

kevin•Documents/Privat/iCal(2.x⚡)» composer install                                                                                                                                                                                    [21:10:51]
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 9 installs, 33 updates, 0 removals
  - Upgrading composer/pcre (3.3.1 => 3.3.2): Extracting archive
  - Upgrading symfony/service-contracts (v3.5.0 => v3.5.1): Extracting archive
  - Upgrading symfony/stopwatch (v7.0.3 => v7.2.2): Extracting archive
  - Upgrading symfony/process (v7.1.7 => v7.2.0): Extracting archive
  - Upgrading symfony/polyfill-php81 (v1.28.0 => v1.31.0): Extracting archive
  - Upgrading symfony/options-resolver (v7.0.0 => v7.2.0): Extracting archive
  - Upgrading symfony/finder (v7.0.0 => v7.2.2): Extracting archive
  - Upgrading symfony/filesystem (v7.1.5 => v7.2.0): Extracting archive
  - Upgrading symfony/event-dispatcher-contracts (v3.5.0 => v3.5.1): Extracting archive
  - Upgrading symfony/event-dispatcher (v7.0.3 => v7.2.0): Extracting archive
  - Upgrading symfony/string (v7.1.5 => v7.2.0): Extracting archive
  - Upgrading symfony/console (v7.1.5 => v7.2.1): Extracting archive
  - Installing react/event-loop (v1.5.0): Extracting archive
  - Installing evenement/evenement (v3.0.2): Extracting archive
  - Installing react/stream (v1.4.0): Extracting archive
  - Installing react/promise (v3.2.0): Extracting archive
  - Installing react/cache (v1.2.0): Extracting archive
  - Installing react/dns (v1.13.0): Extracting archive
  - Installing react/socket (v1.16.0): Extracting archive
  - Installing react/child-process (v0.6.6): Extracting archive
  - Installing clue/ndjson-react (v1.3.0): Extracting archive
  - Upgrading friendsofphp/php-cs-fixer (v3.48.0 => v3.67.0): Extracting archive
  - Upgrading sanmai/pipeline (v6.10 => 6.12): Extracting archive
  - Upgrading phpstan/phpdoc-parser (1.32.0 => 2.0.0): Extracting archive
  - Upgrading doctrine/deprecations (1.1.3 => 1.1.4): Extracting archive
  - Upgrading phpdocumentor/type-resolver (1.8.2 => 1.10.0): Extracting archive
  - Upgrading phpdocumentor/reflection-docblock (5.4.1 => 5.6.1): Extracting archive
  - Upgrading symfony/var-exporter (v7.0.1 => v7.2.0): Extracting archive
  - Upgrading symfony/dependency-injection (v7.0.1 => v7.2.0): Extracting archive
  - Upgrading symfony/config (v7.0.0 => v7.2.0): Extracting archive
  - Upgrading sebastian/resource-operations (3.0.3 => 3.0.4): Extracting archive
  - Upgrading sebastian/global-state (5.0.6 => 5.0.7): Extracting archive
  - Upgrading sebastian/exporter (4.0.5 => 4.0.6): Extracting archive
  - Upgrading sebastian/cli-parser (1.0.1 => 1.0.2): Extracting archive
  - Upgrading theseer/tokenizer (1.2.2 => 1.2.3): Extracting archive
  - Upgrading sebastian/lines-of-code (1.0.3 => 1.0.4): Extracting archive
  - Upgrading sebastian/complexity (2.0.2 => 2.0.3): Extracting archive
  - Upgrading phpunit/php-code-coverage (9.2.29 => 9.2.32): Extracting archive
  - Upgrading phar-io/manifest (2.0.3 => 2.0.4): Extracting archive
  - Upgrading myclabs/deep-copy (1.11.1 => 1.12.1): Extracting archive
  - Upgrading phpunit/phpunit (9.6.15 => 9.6.22): Extracting archive
  - Upgrading spatie/array-to-xml (3.3.0 => 3.4.0): Extracting archive

LordSimal
LordSimal commented Jan 10, 2025
View reviewed changes
Makefile
@@ -29,7 +29,7 @@ test-code-style: vendor

.PHONY: test-psalm
test-psalm: vendor
psalm -m --no-progress ${PSALM_FLAGS}
php -v | grep -q 'PHP 8.3' && psalm -m --no-progress ${PSALM_FLAGS} || true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm does not support 8.4 yet, therefore this makes psalm only run on 8.3

@LordSimal LordSimal mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 deprecations
1 participant
@LordSimal