Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrossValidation cannot select subset of Eloc #58

Closed
laurinbrunner opened this issue Jun 13, 2023 · 0 comments · Fixed by #57
Closed

CrossValidation cannot select subset of Eloc #58

laurinbrunner opened this issue Jun 13, 2023 · 0 comments · Fixed by #57
Labels
bug Something isn't working

Comments

@laurinbrunner
Copy link
Collaborator

laurinbrunner commented Jun 13, 2023 •
edited
Loading

The TDVP class tries to get Eloc[:, 0::2] in its __call__ method if crossValidation is True, but the SampledObs object is not subscriptable.
Also the call of solve still uses the old parameters.
@laurinbrunner laurinbrunner added the bug Something isn't working label Jun 13, 2023
@markusschmitt markusschmitt linked a pull request Jun 14, 2023 that will close this issue
Dev 1.2.2 #57
Merged
@markusschmitt markusschmitt mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev 1.2.2 markusschmitt/vmc_jax
1 participant
@laurinbrunner