-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML not interpreted with CLI #57
Comments
Try
Marp CLI would escape not-whitelisted HTML by default because of several security reason. Refer to: CVE-2017-2239, marp-team/marp-core#9, marp-team/marp-core#26, yhatt/marp#259 |
Ok nice, that worked...but the rendered output is not the same as with Marp. The ## Abstrakte Klassen - Store
<img src="diagrams/store_oop.svg" width="600" align="right">
- Alle Klassen können **instanziert** werden
- Die Kindklassen **müssen** keine Funktion überschreiben
Article a1 = new Article(23, "Test1");
Article a2 = new Book(12, "Test2"); Gets rendered like this: |
In the complete re-written tools released by marp-team, included Marp CLI, you should not expect the exactly same result with yhatt/marp. In this case, yhatt/marp's older Chromium has wrong rendering. According to W3C, the floating element in flexbox is ignored. Marp slide has consisted of flex container, and the floating by ref: https://stackoverflow.com/a/39194800 Instead of  |
Ok, I got it now...I was a bit confused with the difference between marp-cli, marpit, marpcore, marp, and yhatt/marp. Just that I am not missing something: There is currently no marp editor for the new version, which works like yhatt/marp? |
You are right: Currently marp-team have not provide an editor. I have not the time to develop a editor because currently I focus to the minimum viable product, that is the conversion from Markdown to slide deck. At the moment, the most similar usage is the combination with Marp CLI's preview mode ( In future, marp-team/marp-web (In development: https://web.marp.app/) would become a new editor. Sometime I'm going to create blog and explain about the whole of our project clearly. (marp-team/marp#11) Please excuse my lack of explanation! |
Thanks for the clarification (: and great piece of software! 👍 |
I use HTML tags in my presentation to include an image and show it on the right side. Everything works fine while using the marp editor, but when I would like to build it with the CLI version, the HTML tags are not evaluated. Not in
server
orpreview
mode and not withallow-local-files
and not withpdf
orhtml
output.The pdf gets render correctly only when using the
Export to pdf
method in the marp editor itself.Would be great if you could give me a hint. Here are some screenshots of the problem:
Marp editor with html tag
Marp CLI build command
Rendered PDF
The text was updated successfully, but these errors were encountered: