Update dependent packages to latest (Marpit v0.7.1 and Marp Core v0.6.0) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes update of Marpit v0.7.1 and Marp Core v0.6.0.
This reverts commit 3ee722c.
|
An unexpected test example in bespoke plugin would be failed when running |
yhatt
commented
Feb 4, 2019
| description: v => ({ marpCLIDescription: v }), | ||
| image: v => ({ marpCLIImage: v }), | ||
| title: v => ({ marpCLITitle: v }), | ||
| description: v => (typeof v === 'string' ? { marpCLIDescription: v } : {}), |
There was a problem hiding this comment.
Marpit v0.7.1 has updated type definitions to allow array/object passing to custom directives. (marp-team/marpit#130) We have to validate whether meta value is string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependent packages to latest version by using
yarn upgrade --latestyarn upgrade-interactive --latest.This PR is included the update of Marpit v0.7.1 and Marp Core v0.6.0. It has no other changes except Prettier.