You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Some operands will pass the extra_params from client to mars server. But, this PR #2756 changes the operand constructing behaviour, it overwrites the value of extra_params from the kwargs.
# mars/core/operand/base.pyclassOperand(Base, OperatorLogicKeyGeneratorMixin, metaclass=OperandMetaclass):
def__init__(self: OperandType, *args, **kwargs):
self._parse_kwargs(kwargs)
super().__init__(*args, **kwargs)
@classmethoddef_parse_kwargs(cls, kwargs: Dict[str, Any]):
kwargs["extra_params"] =extras=AttributeDict() # <--- Here the extra_params should be initialized from the kwargskwargs["scheduling_hint"] =scheduling_hint=kwargs.get(
"scheduling_hint", SchedulingHint()
)
forkinset(kwargs):
ifkincls._FIELDS:
continueelifkinSchedulingHint.all_hint_names:
setattr(scheduling_hint, k, kwargs.pop(k))
else:
extras[k] =kwargs.pop(k)
To Reproduce
To help us reproducing this bug, please provide information below:
Your Python version 3.7.7
The version of Mars you use Latest master
Versions of crucial packages, such as numpy, scipy and pandas
Describe the bug
Some operands will pass the
extra_params
from client to mars server. But, this PR #2756 changes the operand constructing behaviour, it overwrites the value ofextra_params
from the kwargs.To Reproduce
To help us reproducing this bug, please provide information below:
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: