Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Change License to Apache 2.0 #80

Closed
YouTubePlays opened this issue Sep 2, 2020 · 13 comments
Closed

Request to Change License to Apache 2.0 #80

YouTubePlays opened this issue Sep 2, 2020 · 13 comments

Comments

@YouTubePlays
Copy link

Hello,

@spacemeowx2 has decompiled JoyCon Droid and included transcribed code into this project. I think it is only fair if you change Licence of this project to Apache 2.0 so I don't seem to infract on your licence.

Best

@YouTubePlays
Copy link
Author

Or if you dont want to change the licence you can either grant me an exception or remove revert the mentioned contribution.

@YouTubePlays
Copy link
Author

Transcribed Code Contribution

Proof:
Proof

@spacemeowx2
Copy link
Contributor

That's true. And I'm sorry what I did.

I choice to copy NFC protocol data from the app instead of capturing data by myself. Because I wanted to go shortcut.

@mart1nro
Copy link
Owner

mart1nro commented Sep 2, 2020

@YouTubePlays
I'm sorry this happened and have reverted the mentioned contribution from @spacemeowx2

This means, that currently the nfc emulation support is now removed from joycontrol.

@YouTubePlays
Copy link
Author

@mart1nro if you are willing to give me an exception on your GPL 3.0 then I dont mind it is being included in this repository.

@YouTubePlays
Copy link
Author

Thanks. And Let me know if you change your mind about the subject above.

@choss
Copy link

choss commented Sep 5, 2020

@YouTubePlays: it doesn't work like that.
The only thing what can help is if you (as the author of the original code) grant a GPLv3 licence to to this project for your code. Of course from this point on the implementations might drift a bit...
Everybody who submitted code to this repo here did it under GPLv3 and therefore in order to change the licence, one would have to ask every author.

@corndog2000
Copy link

corndog2000 commented Jan 31, 2021

Is there anyway to get access for the code that has working NFC/Amiibo functionality? That is the only reason I found this repository and now the feature is no longer working.

@andrewthenintendrone
Copy link

@corndog2000 You could always get the commit from right before the functionality was removed.
git reset --hard bf2e7e5

@deltabeard
Copy link

Apache 2 software can therefore be included in GPLv3 projects, because the GPLv3 license accepts our software into GPLv3 works.

https://www.apache.org/licenses/GPL-compatibility.html

My understanding is that there should therefore be no licensing issues here.

@Codingale
Copy link

Codingale commented Mar 22, 2021

https://www.apache.org/licenses/GPL-compatibility.html

My understanding is that there should therefore be no licensing issues here.

Came here to say this after I updated my version and saw this. The only real issue here would be if the reverse happens, which from what I can tell YouTubePlays wanted the code here, but didn't want to relicense their transpiled code, which is fine and means the project didn't need to revert the commit, if you REALLY wanted to you could just add a notice of sub license to the top of the file.

Least reverting reverted commits works mostly fine.

@DanTheMan827
Copy link

DanTheMan827 commented Apr 8, 2021

@YouTubePlays Why not just open source joycon droid, or at least the emulation part of the code.

Multiple groups working towards a common goal means faster discovery of fixes for everyone.

What reason is there to even keep something like this closed source?

@DVDIsDead
Copy link

DVDIsDead commented Apr 27, 2022

What reason is there to even keep something like this closed source?

I second this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants