-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected dihedral parameters from Open Force Field Toolkit #54
Comments
Thanks for the excellent writeup, @martimunicoy. I've checked in the original FFs and those phase values are indeed intentional. I apologize -- I was wrong about this previously. I'm happy to see it's a small number of terms, but I had thought that there were none at all :-/ Would you be up to chat about this soon? In the next year or two, OpenFF is anticipating adding virtual sites (off center charges) to our FFs. It may be worth looking at having PELE energy evaluations in OpenMM, since we work with their development team, and will ensure that it can handle any terms in the force fields we release. |
Thanks for your comment, @j-wags. I guess we will have to modify the current implementation of the torsion equation in PELE. I have already started looking into a workaround. Besides, once you release a FF with virtual sites we will have to implement them into PELE too. Although it seems you do not plan to release a FF with virtual sites anytime soon, we can already start looking at it. We can talk about it this current week, if it suits you (either Wednesday, Thursday or Friday). Thank you again!:) |
Great. I'll coordinate the meeting on Slack :-) |
Description
We noticed that some of the parameters assigned to torsions by the
Open Force Field Toolkit
are unexpected. The current implementation ofoffpele
expects the following values for torsional parameters:phase constant
: either 0.0 or 180.0 degreesperiodicity
: one of (1, 2, 3, 4, 6)See issue #33 for more details.
While the requirement in the
periodicity
value is trivial, thephase constant
does really need to be either 0.0 or 180.0 degrees. That is because of PELE's current dihedral equation (explained here), which is:Since, there is not a
phase constant
term, we need to use theprefactor
which can equal 1 or -1. The sign determines whether the shape of the torsion behaves as inOpen Force Field
with aphase constant
equal to 0.0 or 180.0 degrees. Thus, in case that theOpen Force Field Toolkit
works withphase
values other than 0.0 and 180.0 degrees we will need to change the equation of dihedrals inPELE
.The text was updated successfully, but these errors were encountered: