Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Imbox.delete work #138

Closed
zevaverbach opened this issue Jul 27, 2018 · 5 comments
Closed

make Imbox.delete work #138

zevaverbach opened this issue Jul 27, 2018 · 5 comments

Comments

@zevaverbach
Copy link
Contributor

Currently there's a bug, in that it only calls connection.expunge and doesn't do connection.uid('DELETE').

@sblondon
Copy link
Contributor

sblondon commented Jul 31, 2018

It's a regression in commit 55f64a1 (due probably to an accidental removal of a line).

The PR #147 reintroduce the missing line.

@zevaverbach
Copy link
Contributor Author

zevaverbach commented Jul 31, 2018 via email

@aurelg
Copy link

aurelg commented May 7, 2020

This bug seems to have been reintroduced, see:

imbox/imbox/imbox.py

Lines 65 to 68 in 402d665

def delete(self, uid):
logger.info(
"Mark UID {} with \\Deleted FLAG and expunge.".format(int(uid)))
self.connection.expunge()

@sblondon
Copy link
Contributor

sblondon commented May 8, 2020

@aurelg you're right, the flag is not set.

I'm not sure the maintainer has been notified because the bug report is closed.
@martinrusev did you see it ?

martinrusev added a commit that referenced this issue May 18, 2020
@sla-te
Copy link

sla-te commented May 31, 2020

yeah, i just ran into that as well. im using the version that is pushed to pip so i guess ill switch to the repos one now ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants