Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown encoding in mail header will throw an exception instead of trying default encoding #202

Closed
kapalex opened this issue Jul 20, 2021 · 1 comment
Closed

Unknown encoding in mail header will throw an exception instead of trying default encoding #202

kapalex opened this issue Jul 20, 2021 · 1 comment

Comments

@kapalex
Copy link
Contributor

kapalex commented Jul 20, 2021

Caused by parser.py:42, the logger message is not inside the try...except block, so if it fails to parse the attached encoding it will throw the error instead of trying the default encoding (which is the intended functionality).

Will try to provide a pull request soon.
kapalex added a commit to kapalex/imbox that referenced this issue Jul 20, 2021
@kapalex
fix false exception on unknown encoding martinrusev#202
eb8400a
martinrusev added a commit that referenced this issue Jul 20, 2021
@martinrusev
Merge pull request #203 from kapalex/master
00b21b2 
fix false exception on unknown encoding #202
@ghost
Copy link

ghost commented Jul 27, 2021

This here can be close now as PR #202 is merged

@kapalex kapalex closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kapalex