Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move all code out of __init__.py and into a separate module #130

Closed
zevaverbach opened this issue Jul 25, 2018 · 1 comment · Fixed by #134
Closed

move all code out of __init__.py and into a separate module #130

zevaverbach opened this issue Jul 25, 2018 · 1 comment · Fixed by #134

Comments

@zevaverbach
Copy link
Contributor

zevaverbach commented Jul 25, 2018 •
edited

To follow "the principle of least surprise," as most __init__.pys are empty or only have imports or __all__, and thus that's the expectation. Would you accept a PR implementing this?
@martinrusev
Copy link
Owner

@zevaverbach Makes sense. A separate module plus the imports put in a __all__ list, similar to https://github.com/pallets/jinja/blob/master/jinja2/__init__.py

zevaverbach added a commit to zevaverbach/imbox that referenced this issue Jul 26, 2018
@zevaverbach
moved Messages and Imbox to their own modules, imported Imbox.imbox i…
bd61f8e 
…nto __init__.py and put it in __all__. fixes martinrusev#130.
zevaverbach added a commit to zevaverbach/imbox that referenced this issue Jul 26, 2018
@zevaverbach
Added missing documentation for all supported query keyword arguments. …
9cffb51 
…Fixes martinrusev#124.  Added Pycharm directory to .gitignore.

Fixed var names in documentation of query keywords

moved Messages and Imbox to their own modules, imported Imbox.imbox into __init__.py and put it in __all__. fixes martinrusev#130.

clarified in documentation and Imbox.messages logging that, unless a folder is specified in the kwargs to Imbox.messages, the returned messages will be from the inbox.  In the documentation this is accomplished exclusively by the var names. fixes martinrusev#128.

amended `8df7d7c` to reflect manual changes made to `README.rst` in current master, but also added `inbox_` to several var names to make that explicit in the documentation.  Added flags to messages returned by `fetch_email_by_uid`, using the new function `parse_flags` in `parser.py`.  Fixes martinrusev#126.

added TODO back into query.py
@zevaverbach zevaverbach mentioned this issue Jul 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martinrusev @zevaverbach