Date handling improvement and various fixes #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few things and most importantly the date handling is now locale independent. I thought
strftime
%b
's reliance on the locale was the cause for #160 and #189 but after some testing it seems like as soon as you pass a wrong month (as in not the first 3 letters of a month in English like the RFC specifies it) you get an error (imaplib.IMAP4.error: UID command error: BAD [b'Error in IMAP command UID SEARCH: Invalid search date parameter (0.001 + 0.000 secs).']
) so I don't think these two issues are related to a locale issue.