Base64 decode param and recognize single file mails as attachment #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 24, 2022 22:50
while there seems to be a check for base64 encoding (idicated by "B"), the string was never decoded.
There are some mails, which only consist of attachment without a body. This takes care of application/pdf attachments.
For attachment only email with base64 encoded filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While decode_param() checks for base64 encodig, it actually never was decoded. Works at least for my limited test cases.
Also I encountered messages, which are not multipart and consist only of an attachment. I handled that for application/pdf files. It could be possible to allow a lot more types (or just make an unconditional else), but I'm not certain.