Check SSL-Context for IMAP4_SSL connections #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software was altered, in order to use the systems SSL-Context as default. It allows to toggle the use of the SSL-Default Context. It does not allow to use a custom context. Considerations: * If No SSL-Validation should be done, the ImboxClass should be adapted, in order to achieve configuration of the ssl-context. This commit does not contain this alteration. Other Changes: * Reformatted long lines
This reverts the approach to IMAP transport instantiation back to how it was done prior to 2a0117b which introduced the usesslcontext parameter. This reduces code duplication and importantly make instantiation work again because self.IMAP4 and self.IMAP4_SSL do not exist.
The new ImapTransport parameter ssl_context replaces the usesslcontext parameter and allows the user to supply their own ssl context object. If ssl_context is not given, but ssl is true, python's default ssl context is used. That default context is the one that actually does some certificate checks, such as whether the hostname matches the names given in the server's certificate and not the default context used by IMAP4_SSL when instantiated with ssl_context=None which does not certificate checks at all. The Imbox class is extended with the same ssl_context parameter which is simply passed through to ImapTransport. This commit together with the previous commits from Dustin Demuth changes Imbox in a slightly incompatible way: SSL-Certificates are now checked by default whereas before they were not checked at all. This improves security substantially but users need to be aware that working programs might start raising exceptions due to failing certificate checks.
|
Related issue #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #68 imbox does currently not validate ssl certificates.
This PR introduces this validation.
Please note, that this fix might be incompatible with existing programs which rely on these missing checks.