SSL Broken as of v0.3.8

[itsrachelfish]

SSL connections no longer work after updating to version 0.3.8. This was first noticed on my own self signed network and replicated on DALnet where they use a valid certificate.

There are no error messages by default, but after turning debug to true you see this:

11 Jan 20:59:49 - Connection got "close" event
11 Jan 20:59:49 - Disconnected: reconnecting
11 Jan 20:59:49 - Waiting 2000ms before retrying
11 Jan 20:59:49 - Connection got "end" event
11 Jan 20:59:51 - Connection got "close" event
11 Jan 20:59:51 - Disconnected: reconnecting
11 Jan 20:59:51 - Waiting 2000ms before retrying

[FrobtheBuilder]

Yes, I am also able to replicate this.

[Trinitas]

the server is down? i can't connect to Dalnet without SSL (i get same error)

[ghost]

This appears to be a duplicate of #247. I will note that if I specify a port number, I can connect to freenode. Is there a version where this worked for you? I tried 0.3.7, all the way back to v0.3.0, and none of them can connect to dalnet.

[itsrachelfish]

@apeiron I've created a simple testing project with configurations for various servers. It seems like Freenode is the only major network with a valid certificate. Several others I tried (including Rizon and OFTC) only worked when the selfSigned and certExpired options were enabled, and only in 0.3.7.

I compared these configurations between version 0.3.7 and 0.3.8 by installing from npm and changing the version number in my package.json.

It seems like the root of this bug is actually being caused by how self-signed certificates are handled in 0.3.8.

Here are some examples:
Successful connections to Rizon and OFTC in 0.3.7
Failed connections to Rizon and OFTC in 0.3.8

@Trinitas Interestingly, I can connect to DALnet via irssi but node-irc is unable to connect regardless of what version I'm using.

[ghost]

Okay, this is not a duplicate, but #247 was fixed between the time it was filed and 0.3.7's release (I can connect to oftc fine with the v0.3.7 tag). I've bisected the problem to 96c74ee and will be looking at what specifically broke things. Sorry for the breakage! We're working on writing tests so this sort of thing won't happen again.

[Trinitas]

i get "SELF_SIGNED_CERT_IN_CHAIN" when connecting to irc.oftc.net 6697

[ghost]

Try setting selfSigned: true in the constructor options. I'd suggest re-reading the API docs in general to familiarize yourself with all the options available.

[Trinitas]

still same error

[ghost]

I'm not sure that's possible. At any rate, considering that this is a known bug I'm working on fixing, can we take conversation to IRC?

[ghost]

@Trinitas We are on ##node-irc on freenode if you'd like to join and chat

[ghost]

This is fixed in #304, and we will be testing this today and tomorrow with a release tomorrow evening assuming everything goes well.

[ghost]

Going to close this, as at this point it is a duplicate of #247.