Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'users' of undefined #38

Closed
vorandrew opened this issue Oct 21, 2011 · 0 comments
Closed

Cannot read property 'users' of undefined #38

vorandrew opened this issue Oct 21, 2011 · 0 comments

Comments

@vorandrew
Copy link

See https://github.com/bitcoinjs/node-bitcoin-p2p/issues/38

Half-Shot referenced this issue in matrix-org/node-irc Feb 23, 2019
This fixes part of #38.

It appears to have a conflicting definition (see
https://www.alien.net.au/irc/irc2numerics.html), but this is (1) with a
deprecated AustHex response, or (2) a response from aircd. Seeing as I
cannot *find* aircd, and it does not appear when searching around for
"aircd irc" on DuckDuckGo, I'm proceeding in adding this code as an
unambiguous Unreal code.

If a conflict is found at some future point, I can look into adding to
`parse_message` to check heuristically which of a set of options an
ambiguous code might be. (For example, 378 in Unreal seems to always
start its third argument with "is connecting from".)
Half-Shot referenced this issue in matrix-org/node-irc Feb 23, 2019
Spec: http://ircv3.net/specs/extensions/sasl-3.1.html

Also improves CAP handling, and adds tests to ensure the client handles
relevant SASL messages.

Fixes #38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants