You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it be possible to rollback PR #306, as it breaks this library on ESP8266?
This PR uses an ESPmDNS library, designed for ESP32 only.
If mDNS support is really needed (IMHO, mDNS suport has to be decided in setup() call, not embeded into libraries), it would perhaps be better using ESP8266mDNS. and adding some #define to allow people that don't want to use mDNS to disable it (even if I do continue to think that this should be done into setup(), not in low level library)
Thanks in advance,
The text was updated successfully, but these errors were encountered:
Would it be possible to rollback PR #306, as it breaks this library on ESP8266?
This PR uses an ESPmDNS library, designed for ESP32 only.
If mDNS support is really needed (IMHO, mDNS suport has to be decided in setup() call, not embeded into libraries), it would perhaps be better using ESP8266mDNS. and adding some #define to allow people that don't want to use mDNS to disable it (even if I do continue to think that this should be done into setup(), not in low level library)
Thanks in advance,
The text was updated successfully, but these errors were encountered: