Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rollback PR 306! #309

Open
FlyingDomotic opened this issue Sep 4, 2024 · 2 comments
Open

Please rollback PR 306! #309

FlyingDomotic opened this issue Sep 4, 2024 · 2 comments

Comments

@FlyingDomotic
Copy link

Would it be possible to rollback PR #306, as it breaks this library on ESP8266?

This PR uses an ESPmDNS library, designed for ESP32 only.

If mDNS support is really needed (IMHO, mDNS suport has to be decided in setup() call, not embeded into libraries), it would perhaps be better using ESP8266mDNS. and adding some #define to allow people that don't want to use mDNS to disable it (even if I do continue to think that this should be done into setup(), not in low level library)

Thanks in advance,

@brodrigz
Copy link

The current implementation doesn't even seem to work, this has to be reverted asap

@luebbe
Copy link
Collaborator

luebbe commented Sep 25, 2024

Sorry, I did the rollback, but forgot to confirm the merge. Should hopefully be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants