-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White outline on black emojis rendered unevenly #13766
Comments
Emojione has specifically chosen not to do this, but hasn't stated why. joypixels/emojione#234 |
This svg filter has no artifacting on my browser. Note that the more obvious |
@leo60228 very interesting, thanks! The SVG filters seem to give a pretty good result. I'm worried about performances because of the Gaussian blur filter… but on a quick test, this doesn't seem worse than our existing 4-drop-shadow filter thing. |
The drop shadow trick does four Gaussian blurs, though they each have a radius of 0. I'm not sure if browsers optimize for this case. |
Expected behaviour
I would expect that the white outline (introduced by #8597) on a circular emoji like 🎱 is rendered as a circle.
Actual behaviour
The shape is uneven.
Desktop Firefox (WebRender, AMD, Linux):
Unknown mobile browser (reported by another user):
Steps to reproduce the problem
Place the 🎱 emoji in a display name or message.
Specifications
This occurs on multiple instances. I'm using the v3.1.2 tag, but I don't see any change to the relevant code since it was introduced.
I'm using Firefox 73.0 on Linux with WebRender enabled. I'm not sure what browser the other user is using.
The text was updated successfully, but these errors were encountered: