Various fixes to scrollable lists and media gallery #9501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mastodon#9499 as well as empty timelines' scrollbar “blinking” between loading state and empty state.
(Even though that codepath is probably never actually used…)
Fixes mastodon#9498 Display “load more” more consistently, add a loading indicator on first load.
ykzts
approved these changes
Dec 12, 2018
Gargron
approved these changes
Dec 12, 2018
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Always use the scrollable class for the ScrollList component Fixes mastodon#9499 as well as empty timelines' scrollbar “blinking” between loading state and empty state. * Do not display empty message when the list is known to have more elements Fixes mastodon#9500 * Fix LoadMore usage in account media gallery (Even though that codepath is probably never actually used…) * Make account media gallery more consistent with account timeline Fixes mastodon#9498 Display “load more” more consistently, add a loading indicator on first load. * Fix “load more” button when no data has been fetched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always display a scrollbar for components using
ScrollableList, display “load more” whenever some list is known to have more items even if no items have been retrieved so far, and display a loading indicator in account gallery timelines on first load.