This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Add support for multiple GOPATHs #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for multiple entries in the GOPATH variable, which has the benefit that downloaded packages are placed in the path the first entry of GOPATH while own packages can be managed in the second path.
matchai
approved these changes
Feb 17, 2019
There was a problem hiding this comment.
Looks good to me!
Thank you for the contribution @DanielTrautmann! 😄
matchai
pushed a commit
that referenced
this pull request
Feb 17, 2019
## [2.2.4](v2.2.3...v2.2.4) (2019-02-17) ### Bug Fixes * don't throw errors when there are multiple GOPATHs ([#158](#158)) ([653f1c8](653f1c8))
|
🎉 This PR is included in version 2.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@all-contributors please add @DanielTrautmann for code |
|
I've put up a pull request to add @DanielTrautmann! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for multiple entries in the GOPATH variable, which has the benefit that downloaded packages are placed in the path of the first entry of GOPATH while own packages can be managed in the second path.
Description
I replaced
[ -n $GOPATH ]by[ (count $GOPATH) -gt 0 ]infunctions/__sf_section_golang.fish.Motivation and Context
Closes #157
Types of changes
How Has This Been Tested?
I ran
npm test.Checklist: