This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Fix typo in venv generic names variables #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @k-lyda for bug |
|
I've put up a pull request to add @k-lyda! 🎉 |
matchai
pushed a commit
that referenced
this pull request
Mar 2, 2019
## [2.3.1](v2.3.0...v2.3.1) (2019-03-02) ### Bug Fixes * correct typo in venv configuration variables ([#167](#167)) ([8a3585c](8a3585c))
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matchai
added a commit
that referenced
this pull request
Mar 2, 2019
Adds @k-lyda as a contributor for bug. This was requested by matchai [in this comment](#167 (comment)) Co-authored-by: null <allcontributors[bot]@users.noreply.github.com> Co-authored-by: Matan Kushner <hello@matchai.me>
adamsimp
pushed a commit
to adamsimp/spacefish
that referenced
this pull request
May 6, 2019
adamsimp
pushed a commit
to adamsimp/spacefish
that referenced
this pull request
May 6, 2019
## [2.3.1](matchai/spacefish@v2.3.0...v2.3.1) (2019-03-02) ### Bug Fixes * correct typo in venv configuration variables ([matchai#167](matchai#167)) ([8a3585c](matchai@8a3585c))
adamsimp
pushed a commit
to adamsimp/spacefish
that referenced
this pull request
May 6, 2019
Adds @k-lyda as a contributor for bug. This was requested by matchai [in this comment](matchai#167 (comment)) Co-authored-by: null <allcontributors[bot]@users.noreply.github.com> Co-authored-by: Matan Kushner <hello@matchai.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think this there is a leftover from migrating venv section from Spaceship prompt - name of the variable containing venv generic names is
SPACESHIP_VENV_GENERIC_NAMESinstead ofSPACEFISH_VENV_GENERIC_NAMESMotivation and Context
In the documentation name for this var is
SPACEFISH_VENV_GENERIC_NAMES. If you add a line to config.fish according to the documentation, the generic names array is not updated, cause spaceship does not take varSPACEFISH_VENV_GENERIC_NAMESinto account, it only looks forSPACESHIP_VENV_GENERIC_NAMESTypes of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: