This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
feat: add cargo package manager and refactor existing package #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
reviewed
Mar 3, 2019
matchai
reviewed
Mar 3, 2019
matchai
reviewed
Mar 3, 2019
matchai
previously requested changes
Mar 3, 2019
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>
|
@sirMerr You may want to update the documentation in Options.md to mention the new Cargo support in the package section: https://github.com/matchai/spacefish/blob/master/docs/Options.md#package-version-package Here is the equivalent spaceship documentation: https://github.com/denysdovhan/spaceship-prompt/blob/master/docs/Options.md#package-version-package |
Snuggle
reviewed
Mar 7, 2019
matchai
approved these changes
Mar 8, 2019
|
@all-contributors please add @sirMerr for tests |
|
I've put up a pull request to add @sirMerr! 🎉 |
matchai
pushed a commit
that referenced
this pull request
Mar 8, 2019
# [2.4.0](v2.3.1...v2.4.0) (2019-03-08) ### Features * add cargo package manager and refactor existing package section ([#171](#171)) ([0064d2d](0064d2d))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
adamsimp
pushed a commit
to adamsimp/spacefish
that referenced
this pull request
May 6, 2019
…matchai#171) ✨🔨 Refactor package to include cargo, and use jq and python for node
adamsimp
pushed a commit
to adamsimp/spacefish
that referenced
this pull request
May 6, 2019
# [2.4.0](matchai/spacefish@v2.3.1...v2.4.0) (2019-03-08) ### Features * add cargo package manager and refactor existing package section ([matchai#171](matchai#171)) ([0064d2d](matchai@0064d2d))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make package section support cargo package manager. Additionally, update current implementation of
__sf_section_package.fishto usejqandpythonto go throughpackage.jsonasspaceshipdoes as a performance boost.Motivation and Context
Closes #143
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: