This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
feat(aws): Support aws-vault as an option instead of named AWS profiles #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using [99designs/aws-vault](https://github.com/99designs/aws-vault) the variable `AWS_VAULT` is set to indicate which profile has been configured in the environment and the AWS_PROFILE environment variable is not set. This commits makes AWS_VAULT override the profile name.
matchai
approved these changes
Aug 21, 2019
|
@all-contributors please add @kouk for code and test. |
|
I've put up a pull request to add @kouk! 🎉 |
matchai
pushed a commit
that referenced
this pull request
Aug 21, 2019
# [2.7.0](v2.6.1...v2.7.0) (2019-08-21) ### Features * **aws:** Support aws-vault as an option instead of named AWS p… ([#206](#206)) ([5e02e3f](5e02e3f))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the AWS function to optionally retrieve the profile name from the
AWS_VAULTenvironment variable instead ofAWS_PROFILE.Motivation and Context
When using 99designs/aws-vault the variable
AWS_VAULTis set to indicate which profile has been configured in the environment and the AWS_PROFILE environment variable is not set. This commits makes AWS_VAULT override the profile name.Types of changes
How Has This Been Tested?
Checklist: