-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable per-PR preview builds in netlify #191
Comments
This is a setting in Netlify configuration... I am getting these PR previews in my site which uses Learn Theme, but I believe this particular setting is not part of the theme, because it depends on how you're deploying the site you build with the theme. This is an excellent Netlify feature, by the way. Do you think anything else needs to be done in the Theme files for this? Or were you just adding this Issue as a "note to self", as a reminder? :-) |
This is a note-to-self. I don't think anything needs changing in the theme to achieve this. |
Unsetting the environment variable I do see an issue with the theme trying to load index.json (for search) without a baseurl. Looking into this before closing ticket but will leave the variable deleted |
In my site Preview builds (and all other builds) work well, with https://github.com/salesagility/SuiteDocs/blob/master/netlify.toml |
Excellent, do you give me permission to copy your netlify file? The original maintainer only configured netlify via the UI and the baseurl was set global, which broke all preview builds. |
Sure, go ahead. |
https://app.netlify.com/sites/learn/settings/deploys
The text was updated successfully, but these errors were encountered: