generated from mate-academy/react_people-table
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #1135
Open
roman-logos-frontend
wants to merge
1
commit into
mate-academy:master
Choose a base branch
from
roman-logos-frontend:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add task solution #1135
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,60 @@ | ||
import React, { useEffect, useState } from 'react'; | ||
import { PeopleFilters } from './PeopleFilters'; | ||
import { Loader } from './Loader'; | ||
import { PeopleTable } from './PeopleTable'; | ||
import { getPeople } from '../api'; | ||
import { Person } from '../types'; | ||
import { useSearchParams } from 'react-router-dom'; | ||
|
||
export const PeoplePage = () => { | ||
const [people, setPeople] = useState<Person[]>([]); | ||
const [loading, setLoading] = useState(true); | ||
const [error, setError] = useState<string | null>(null); | ||
|
||
useEffect(() => { | ||
const fetchPeople = async () => { | ||
try { | ||
setLoading(true); | ||
const data = await getPeople(); | ||
|
||
setPeople(data); | ||
setLoading(false); | ||
} catch (e) { | ||
setError('Something went wrong'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider providing more detailed error information to the user, if available. This can help users understand what went wrong and potentially how to fix it. You might want to log the actual error message or display it conditionally. |
||
setLoading(false); | ||
} | ||
}; | ||
|
||
fetchPeople(); | ||
}, []); | ||
|
||
const [searchParams] = useSearchParams(); | ||
|
||
const query = searchParams.get('query')?.toLowerCase() || ''; | ||
const sex = searchParams.get('sex'); | ||
const selectedCenturies = searchParams.getAll('centuries'); | ||
|
||
const isInSelectedCenturies = (person: Person) => { | ||
if (selectedCenturies.length === 0) { | ||
return true; | ||
} | ||
|
||
return selectedCenturies.some(century => { | ||
const startYear = (parseInt(century, 10) - 1) * 100 + 1; | ||
const endYear = startYear + 99; | ||
|
||
return person.born >= startYear && person.born <= endYear; | ||
}); | ||
}; | ||
|
||
const filteredPeople = people.filter(person => { | ||
const matchesQuery = person.name.toLowerCase().includes(query); | ||
const matchesSex = !sex || person.sex === sex; | ||
const matchesCentury = isInSelectedCenturies(person); | ||
|
||
return matchesQuery && matchesSex && matchesCentury; | ||
}); | ||
|
||
return ( | ||
<> | ||
<h1 className="title">People Page</h1> | ||
|
@@ -15,15 +67,19 @@ export const PeoplePage = () => { | |
|
||
<div className="column"> | ||
<div className="box table-container"> | ||
<Loader /> | ||
|
||
<p data-cy="peopleLoadingError">Something went wrong</p> | ||
|
||
<p data-cy="noPeopleMessage">There are no people on the server</p> | ||
|
||
<p>There are no people matching the current search criteria</p> | ||
|
||
<PeopleTable /> | ||
{loading && <Loader />} | ||
{error && <p data-cy="peopleLoadingError">{error}</p>} | ||
{!loading && !error && people.length === 0 && ( | ||
<p data-cy="noPeopleMessage"> | ||
There are no people on the server | ||
</p> | ||
)} | ||
{!loading && !error && filteredPeople.length > 0 && ( | ||
<PeopleTable people={filteredPeople} /> | ||
)} | ||
{!loading && !error && filteredPeople.length === 0 && ( | ||
<p>There are no people matching the current search criteria</p> | ||
)} | ||
</div> | ||
</div> | ||
</div> | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
toggleCentury
function is called directly within theparams
prop ofSearchLink
. This means it will be executed on every render, which could lead to unexpected behavior. Consider refactoring this logic to ensuretoggleCentury
is only called when necessary, such as within an event handler.