Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #1143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #1143

wants to merge 2 commits into from

Conversation

Daryna-Kukharets
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 28, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Your implementation meets all the task requirements and constraints, with well-structured components and correct use of React and React Router practices. The filtering and sorting functionalities are effectively integrated, and the code is clean and functional. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 29, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
Don't need to reset filters after clicking on the person
image
image
image

src/components/PeopleFilters.tsx Outdated
</SearchLink>
<SearchLink
className={classNames({ 'is-active': isActiveSex('m') })}
params={{ sex: 'm' }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a enum for 'm', 'f' and use it everywhere

volodymyr-soltys97
volodymyr-soltys97 approved these changes Nov 30, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daryna-Kukharets @volodymyr-soltys97 @mateacademy-ai-mentor