Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line endings on Docker #129

Closed
felipecrs opened this issue Aug 3, 2020 · 0 comments · Fixed by #135
Closed

Line endings on Docker #129

felipecrs opened this issue Aug 3, 2020 · 0 comments · Fixed by #135

Comments

@felipecrs
Copy link
Contributor

Currently, if you use Argbash Docker, it warns you in case it doesn't find a -o option because it would return the output with CRLF line endings instead of LF.

But in fact, Docker only outputs CRLF if you use -it. If you use docker run --rm matejak/argbash, it will return LF line endings.

The question is: is -it really needed (because of the interactive terminal)? If yes, is it only needed on argbash-init? If yes again, it should be only included in the argbash-init docker shim so. And then, we could remove this validation in the entrypoint.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant