Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little changes in MDC Toolbar #790

Closed
touficbatache opened this issue Jun 5, 2017 · 1 comment
Closed

Little changes in MDC Toolbar #790

touficbatache opened this issue Jun 5, 2017 · 1 comment
Assignees
@amsheehan

Comments

@touficbatache
Copy link
Contributor

Hey,
In MDC Toolbar, the title has a left-margin of 16px.

The problems with that are:

  1. If you remove the left menu icon, the title will have a wrong padding on the left.
  2. According to Material Design Guidelines, the margin shouldn't be 16px. The margin from the left of the screen is 16, the width of the icon is 24, and the title is 72 away from the screen so we get 72 - 24 - 16 = 32px which is the distance between the icon and the title.
    image

The solution is to add a margin-right to the left menu icon of 32px.

I am ready to make a PR to fix this.
@touficbatache touficbatache mentioned this issue Jun 7, 2017
Merged
@amsheehan amsheehan self-assigned this Jun 8, 2017
@touficbatache touficbatache mentioned this issue Jun 10, 2017
Closed
@touficbatache
Copy link
Contributor Author

After updating MDC-Web, everything seems correct and there's no need for any change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amsheehan amsheehan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amsheehan @touficbatache