Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap doesn't update Material 3 Design Kit components properly #351

Open
OnkelTem opened this issue Oct 26, 2024 · 1 comment
Open

Swap doesn't update Material 3 Design Kit components properly #351

OnkelTem opened this issue Oct 26, 2024 · 1 comment

Comments

@OnkelTem
Copy link

OnkelTem commented Oct 26, 2024

Let's prepare our theme using Material Theme Builder:

image

this is my settings:

image

Now let's import the Navigation bar component:

image

Now let's swap its colors with our theme's ones. So I'm about to click the (1) button:

image

Result:

image

Now. Let's change to "Selected" property of the second button "Saved":

image

Notice that:

  1. The Selected property is now ON
  2. But the color is the old one, so it was not updated.
  3. And indeed, the "Selection colors" list shows that two colors were not swapped.

Is it by design? How to effectively swap colors or is it actually impossible and then... what is this all about then?

@HZRDUS
Copy link

HZRDUS commented Oct 31, 2024

Unfortunately, if using the UI kit, you need to manually update the colors for each variant. Be careful with this route however as library updates will override your color selections or could override other local changes. You can instead duplicate the Material 3 Design Kit community file, and the plugin will update those components. You could also do what I did and copy certain components that I want from the duplicated file into my own file. That way you don't have a large file with a lot of components you may not need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants