Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export for angular-material #38

Closed
danitag78 opened this issue Feb 10, 2022 · 10 comments · May be fixed by #68
Closed

Export for angular-material #38

danitag78 opened this issue Feb 10, 2022 · 10 comments · May be fixed by #68
Labels
enhancement New feature or request

Comments

@danitag78
Copy link

Is it possible to add export for scss file to use with angular-material with extended colours?

@rodydavis
Copy link
Member

I can look into adding sass/scss export!

Given the current css could you paste an example of the ideal layout?

@margeeta margeeta added the enhancement New feature or request label May 6, 2022
@yegor-pelykh
Copy link

I need export for Angular Material too, as well as many other people.

@kintz09
Copy link

kintz09 commented Mar 27, 2023

I'm not using Angular, but would also love to be able to export the theme to Sass (scss preferred) instead of just css. Especially if there were some useful mixins available in that export.

@Fitzchev
Copy link

Fitzchev commented Jun 7, 2023

I don't see any progress here despite a PR from @twerske from last year still open. Is it likely to happen?

@marc-wilson
Copy link

marc-wilson commented May 29, 2024

+1. I'm kind of shocked there's no export option for angular. I was thinking there was some hidden theme option to load up the JSON export, but I'm not seeing anything there either.

Just seems like angular is up there in what would be considered a default export for something like this.

@themocs
Copy link

themocs commented Jun 12, 2024

I think it's because they only support android development over desktop.

@margeeta
Copy link
Collaborator

Hey y'all,
We decided to go with CSS export to support a wider range of instead of focusing on specific web frameworks.

@themocs
Copy link

themocs commented Jun 12, 2024

@margeeta It's not planned support to SCSS file export? SASS it's was a great improvement over site personalization, why not make it available?

@marc-wilson
Copy link

@margeeta I understand your point, but it seems a bit contradictory. Google, the creator of the Material Design Specification, also owns Flutter and Angular. So, it would be logical to provide something tailored for Angular (you've done so for Flutter).

The purpose of the tool is to simplify theme customization and then allow easy export for integration with underlying technologies. You've achieved this for Flutter, which is understandable. Similarly, not doing so for Swift also makes sense. However, not having a similar solution for Angular is puzzling.

While there is a generic CSS file, it often requires substantial modification to work properly with the underlying application or framework. Given that Angular Material is commonly used with Angular, it would be more practical to avoid a generic CSS file for any web app (which isn’t always the case) and instead support frameworks that are inherently based on Material Design (like Angular and Flutter). Angular Material see's this css file as an anti pattern. There is a very opinionated/specific way to setup theming in order for it to work properly and follow the Material Spec to the T.

In my opinion, not supporting an Angular Material specific export is a significant oversight.

@singatias
Copy link

Reopening the issue since it was never merged. I want to point out that the current PR was submitted in may 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants