Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gruntfile #333

Merged
merged 114 commits into from
Feb 10, 2023
Merged

Improve gruntfile #333

merged 114 commits into from
Feb 10, 2023

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Feb 8, 2023

Proposed changes

Collect Files dynamically for PUG Transpiling of docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Alan Chang and others added 30 commits June 1, 2020 09:39
I'm still wondering why the font section have been deleted...
See : https://git.io/JK9is

Closes #175
I'm removing the most of the section about the Roboto Font by just
keeping the "how to change the font stack" part.

Fixes #175
…t stack"

this applies the suggested changed of this review :
#212 (comment)
Fix #175 : Add a docs section on how to change the font stack
…sion, and minor changes

- Added the community as part of the team, by explaining why we forked the repo and by adding a
dynamic image that show the top 24 contributors. Prob is that it don't sort by team members but
rather by commit numbers - Added a message in the index page that says this version is a fork -
Changeed the catchphrase in the homepage - Rephrased a sentence inside the introduction grid shown
in the homepage and grid section

fix #194
docs: rework about and home page to mention this is the community fork
docs(select): rephrase a sentence in select docs, issue 171
* fix: add link to searchable list #225

* Update pug/page-contents/icons_content.html

Co-authored-by: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
Refactored Select internaly for Arrays to prepare for other changes
* with the CHANGELOG now generated by github_changelog_generator
* update package-lock.json file version
   * because I used node 16
* more changes after running npm run release
Chicken and others added 25 commits November 30, 2022 22:21
fix: remove postinstall hook from packed package
also make the copyright follow current year
Fix missed files when replacing old version with new one
Assign "aria-required" attribute to input element rather than dropdown.
Fix broken references in FAB toolbar demo page.
fix(select): misplaced aria-required attribute
this commit adds examples to the alignment option in documentation

Signed-off-by: Cypherpunk Samurai <66906402+CypherpunkSamurai@users.noreply.github.com>
Added Example for alignment option
Fix navbar lists not expanding when on page Feature Discovery
Ignore html and body element when looking for dropdown placement
fix: add permission to execute commit-msg hook
Documentation: renamed master to main and changed year
@wuda-io wuda-io merged commit aeb08aa into materializecss:v2-dev Feb 10, 2023
@wuda-io wuda-io deleted the improve-gruntfile branch February 10, 2023 21:36
@Smankusors
Copy link
Member

eh uh... what is this PR about and why there is so many changes? 😅

@wuda-io
Copy link
Member Author

wuda-io commented Feb 18, 2023

eh uh... what is this PR about and why there is so many changes? sweat_smile

the last commit is the actual improvement. Actually i wanted to test a PR merge to the new dev-branch.

We should start to merge new features into the dev-branch and only hotfixes to the main branch.
see here: https://stackoverflow.com/questions/32826370/why-do-we-need-dev-branch
What are your thoughts?

The many commits were automatically added by Github and were taken from the main branch. So the dev-branch should now be up-to-date with the main branch.

@Smankusors
Copy link
Member

ou I see
sorry if I'm kinda gone missing, I got busy elsewhere and I don't think I have time maintaining this anymore 😢

at first time reading this PR I got suprised because there's a lot of changes. If you want to sync branches, it should be on a separate PR so it's easier to understand. But I saw your recent PRs, you already do that so it's good then 👍

thanks for continuing the development btw 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.