Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar-link, workflow and serve docs directly via grunt #342

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: navbar-link, workflow and serve docs directly via grunt #342

merged 1 commit into from
Mar 6, 2023

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Mar 6, 2023

Proposed changes

  • changed workflow to work with cname, otherwise gh-pages-workflow overwrites custom domain
  • rootfolder of grunt to docs/
  • navabarlink to root-folder (so it works on every domain)

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io mentioned this pull request Mar 6, 2023
3 tasks
@wuda-io wuda-io merged commit dd0ac68 into materializecss:main Mar 6, 2023
@wuda-io wuda-io deleted the fix-workflow-ghpages-and-docs branch March 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant