Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tabs not directly managing content #366

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

danice
Copy link

@danice danice commented May 6, 2023

Proposed changes

For tabs component: minor changes to maintain option to use only the tabs part, without managing the content associated to each tab.
This was working in previous version just not defining the href for each tab anchor element.

Types of changes

Just adding missing null / empty checks for href element.
In existing version there was this null checks in many places (for example in _setupNormalTabs method), but it was missing in some other places.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Jerit3787 Jerit3787 requested a review from a team May 7, 2023 14:36
src/tabs.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit 51296e1 into materializecss:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants