Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly builds #63

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Nightly builds #63

merged 1 commit into from
Jan 11, 2021

Conversation

ChildishGiant
Copy link
Member

@ChildishGiant ChildishGiant commented Jan 10, 2021 •
edited
Loading

Uses Github Actions (#17) to build on new commits and weekly (in case there are no new commits). Here's an example run: https://github.com/ChildishGiant/materialize/actions/runs/476340135

The workflow's very simple, it just runs all tests, builds and then uploads the build.
There's currently no simple way of linking users to the latest build (actions/upload-artifact#52) but it's something for the people waiting on nightly builds (Ping for those in #13). We could link to nightly.link in the meantime (https://nightly.link/ChildishGiant/materialize/workflows/nightly/GHA/build) or the equivalent for this repo

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ChildishGiant
Nightly builds
58d1800 
Builds on new commits and weekly
@DanielRuf DanielRuf requested a review from a team January 11, 2021 10:22
@Smankusors Smankusors mentioned this pull request Jan 11, 2021
Closed
Pierstoval
Pierstoval reviewed Jan 11, 2021
View reviewed changes
Copy link

@Pierstoval Pierstoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice contribution, and thanks for making me discover nightly.link! I might use it in other projects 😉

I am okay with this external service for now, until Github creates a way to get a link to latest releases, so LGTM 👍

@DanielRuf DanielRuf merged commit a748515 into materializecss:v1-dev Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Pierstoval Pierstoval Pierstoval approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChildishGiant @Pierstoval @roiLeo @DanielRuf @Smankusors