Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pymatgen from 2023.12.18 to 2024.1.27 #693

Closed
wants to merge 5 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps pymatgen from 2023.12.18 to 2024.1.27.

Release notes

Sourced from pymatgen's releases.

v2024.1.27

Full Changelog: materialsproject/pymatgen@v2024.1.26...v2024.1.27

v2024.1.26

What's Changed

🐛 Bug Fixes

🛠 Enhancements

🧹 House-Keeping

🧪 Tests

💥 Breaking Changes

🤷‍♂️ Other Changes

... (truncated)

Changelog

Sourced from pymatgen's changelog.


layout: default title: Change Log nav_order: 4

Changelog

v2024.1.26

🐛 Bug Fixes

🛠 Enhancements

🧹 House-Keeping

... (truncated)

Commits
  • ac8a7e9 Update docs
  • 5137111 Fix monty version.
  • 575f404 v2024.1.26
  • e9cc87a remove unneeded unittest tearDown methods
  • 9a0eb81 Breaking: remove single-use PolarizationLattice which inherited from `Struc...
  • f345f2f test nested square bracket in formula strings
  • 9604d75 Allow square brackets in composition. Fixes #3583.
  • c0c40dd fix variable clash "dist" in zero_d_graph_to_molecule_graph() introduced in 7...
  • cb2f490 Added threshold_ordering parameter to CollinearMagneticStructureAnalyzer in a...
  • 0b8be98 Support parsing of "final_energy" in Q-Chem 6.1.1 (#3580)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pymatgen](https://github.com/materialsproject/pymatgen) from 2023.12.18 to 2024.1.27.
- [Release notes](https://github.com/materialsproject/pymatgen/releases)
- [Changelog](https://github.com/materialsproject/pymatgen/blob/master/docs/CHANGES.md)
- [Commits](materialsproject/pymatgen@v2023.12.18...v2024.1.27)

---
updated-dependencies:
- dependency-name: pymatgen
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 29, 2024
@utf
Copy link
Member

utf commented Feb 1, 2024

Hi @janosh, do you have any idea what could be causing the errors with the new pymatgen version?

@janosh
Copy link
Member

janosh commented Feb 1, 2024

@utf this error

  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/atomate2/vasp/sets/base.py", line 556, in _get_previous
    vasprun, outcar = get_vasprun_outcar(prev_dir)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pymatgen/io/vasp/sets.py", line 2734, in get_vasprun_outcar
    Vasprun(vsfile, parse_dos=parse_dos, parse_eigen=parse_eigen),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py", line 296, in __init__
    self.update_potcar_spec(parse_potcar_file)
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py", line 1054, in update_potcar_spec
    if potcar := self.get_potcars(path):
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pymatgen/io/vasp/outputs.py", line 1010, in get_potcars
    f"{search_path}/{fn}" for fn in os.listdir(search_path) if fn.startswith("POTCAR") and ".spec" not in fn

was fixed in materialsproject/pymatgen#3587 and released in https://github.com/materialsproject/pymatgen/releases/tag/v2024.2.1

@janosh janosh enabled auto-merge (squash) February 1, 2024 12:08
@janosh
Copy link
Member

janosh commented Feb 1, 2024

hold on, pmg release didn't actually make it to PyPI because i changed to the new (now free) macOS M1 runners which as discussed here don't ship with pipx, causing wheel building to fail.

@janosh
Copy link
Member

janosh commented Feb 8, 2024

@utf @JaGeo the 4 remaining failing tests raise in generate_phonon_displacements due to the changes in materialsproject/pymatgen#3555.

INFO     jobflow.managers.local:local.py:118 generate_phonon_displacements failed with exception:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/jobflow/managers/local.py", line 114, in _run_job
    response = job.run(store=store)
               ^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/jobflow/core/job.py", line 583, in run
    response = function(*self.function_args, **self.function_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/atomate2/common/jobs/phonons.py", line 166, in generate_phonon_displacements
    phonon = Phonopy(
             ^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/phonopy/api_phonopy.py", line 171, in __init__
    self._primitive_matrix = self._set_primitive_matrix(primitive_matrix)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/phonopy/api_phonopy.py", line 3830, in _set_primitive_matrix
    return guess_primitive_matrix(self._unitcell, symprec=self._symprec)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/phonopy/structure/cells.py", line 1693, in guess_primitive_matrix
    raise RuntimeError(msg)
RuntimeError: Can not be used with the unit cell having magnetic moments.

@JaGeo
Copy link
Member

JaGeo commented Feb 8, 2024

I think there was a discussion about this already in the pull request how one can solve it. (see materialsproject/pymatgen#3555 (comment)).

@tpurcell90 tpurcell90 mentioned this pull request Feb 8, 2024
5 tasks
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 12, 2024

A newer version of pymatgen exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@utf
Copy link
Member

utf commented Feb 14, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 14, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@utf
Copy link
Member

utf commented Feb 14, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 14, 2024

Superseded by #719.

@dependabot dependabot bot closed this Feb 14, 2024
auto-merge was automatically disabled February 14, 2024 09:59

Pull request was closed

@dependabot dependabot bot deleted the dependabot/pip/pymatgen-2024.1.27 branch February 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants