-
Notifications
You must be signed in to change notification settings - Fork 868
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Breaking: Default
user_potcar_settings
to {"W": "W_sv"}
in all in…
…put sets if `user_potcar_functional == "PBE_54"` (#3022) * DictSet drop deprecated kwarg potcar_functional: str = None, use user_potcar_functional: str = None instead * default user_potcar_settings to {"W": "W_sv"} in all input sets if user_potcar_functional == "PBE_54" * fix typos * fix TypeError: 'NoneType' object is not iterable in kwargs["user_potcar_settings"] = {"W": "W_sv"}.update(kwargs.get("user_potcar_settings", {})) pymatgen/io/vasp/sets.py:2352 also address #3022 (comment) by moving {"W": "W_sv"} logic into DictSet * remove test_potcar_functional_warning() * VaspInputSet add static attr _valid_potcars: Sequence[str] | None = None for DRY ValueError on invalid user_potcar_functional * only default user_potcar_settings to {"W": "W_sv"} if structure contains tungsten also fix #3022 (comment) * pymatgen/io/vasp/tests/test_sets.py add test_potcar_special_defaults()
- Loading branch information
Showing
4 changed files
with
128 additions
and
124 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.